CLDR-17425 Fix bugs involving locale USER #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Include real locale ID as json.loc in server response for page request -Use optional chaining (?.) operator for special_type which may be undefined for USER -Do not call dispatchEvent or setRef from setCurrentLocale for locale USER -New method UserRegistry.substituteUserWildcardLocale replacing inline code in SurveyAjax, now called also by VoteAPIHelper
srl295
reviewed
Mar 20, 2024
| @@ -1055,21 +1055,7 @@ public static CLDRLocale validateLocale(PrintWriter out, String loc, String sess | |||
| * loc can have either - or _; normalize to _ | |||
| */ | |||
| loc = loc.replace('-', '_'); | |||
There was a problem hiding this comment.
do we need this line ? or maybe it should also go into a utility function?
There was a problem hiding this comment.
I think we have to assume it's needed... ideally it should be encapsulated in a module specific to locales, not SurveyAjax; and as much as possible we should pass around CLDRLocale objects instead of strings...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Include real locale ID as json.loc in server response for page request
-Use optional chaining (?.) operator for special_type which may be undefined for USER
-Do not call dispatchEvent or setRef from setCurrentLocale for locale USER
-New method UserRegistry.substituteUserWildcardLocale replacing inline code in SurveyAjax, now called also by VoteAPIHelper
CLDR-17425
ALLOW_MANY_COMMITS=true